Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verticalAlignment "middle" and "center" crash the app on Android #1822

Closed
alg opened this issue Mar 22, 2016 · 1 comment
Closed

verticalAlignment "middle" and "center" crash the app on Android #1822

alg opened this issue Mar 22, 2016 · 1 comment
Labels
bug done
Milestone
2.0.0

Comments

@alg
Copy link
Contributor

alg commented Mar 22, 2016

We discovered that these two values crash the app on Android. I found that it happens because of bad case-statement that looks like this:

case VerticalAlignment.center || VerticalAlignment.middle:

The default case picks up everything that doesn't match and raises an error for an unrecognized option.

Affected files:

  • ui/core/view.android.ts
  • ui/core/view-common.ts
  • ui/layouts/stack-layout/stack-layout.ios.ts

I'm submitting PR to resolve this in a minute.
@alg alg mentioned this issue Mar 22, 2016
Merged
@enchev enchev added the bug label Mar 22, 2016
@enchev enchev added this to the 2.0.0 (Under review) milestone Mar 22, 2016
@enchev enchev added the done label Mar 22, 2016
@enchev enchev closed this as completed Mar 22, 2016
@lock
Copy link

lock bot commented Aug 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug done
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@alg @enchev