Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lenient mode tweaks #63

Closed
remiolsen opened this issue Jan 24, 2024 · 1 comment · Fixed by #77
Closed

Lenient mode tweaks #63

remiolsen opened this issue Jan 24, 2024 · 1 comment · Fixed by #77
Assignees
Labels
bug Something isn't working
Milestone

Comments

@remiolsen
Copy link
Member

remiolsen commented Jan 24, 2024

The decision to flip indices needs to be weighted by the amount of reads with "unknown" barcodes. For instance currently it can decide to flip I7 if it will go from 1 read to 10 reads demuxed, whereas there might be 100k reads with unknown.

Edit: for my own reference, see run 20240118_1039_MN19414_ASG790_ae66b218

@remiolsen remiolsen added this to the 1.0.0 milestone Jan 24, 2024
@remiolsen remiolsen added the enhancement New feature or request label Jan 25, 2024
@remiolsen
Copy link
Member Author

This is a bug! Output from lenient mode for a pol (internal note: run on flowcell 20240125_1233_MN19414_API303_1947636a):

DEBUG:anglerfish: Matched 0 reads, unmatched 188763 reads
DEBUG:anglerfish: Matched 0 reads, unmatched 181962 reads
DEBUG:anglerfish: Matched 198071 reads, unmatched 12537 reads
DEBUG:anglerfish: Matched 2 reads, unmatched 191222 reads <--- Lenient mode selected this one!!!

This shows out of the four possible orientations: original, revcomp i7, revcomp i5 and revcomp both it did not make the obvious choice which would yield many more matched reads.

@remiolsen remiolsen added bug Something isn't working and removed enhancement New feature or request labels Feb 14, 2024
@remiolsen remiolsen self-assigned this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant