Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add SonarTS checks to our current TSLint checks #331

Closed
christophercr opened this issue Apr 25, 2018 · 1 comment
Closed

build: add SonarTS checks to our current TSLint checks #331

christophercr opened this issue Apr 25, 2018 · 1 comment
Labels
comp: build-main Main build comp: qa comp: stark-all To apply for all Stark modules P2
Milestone
10.0.0-alpha.3

Comments

@christophercr
Copy link
Collaborator

Sonar checks for TS with TSLint! Now that Stark is an open source project which anyone can contribute to, I think this is definitely something we should add:

https://github.com/SonarSource/SonarTS

What do you think? @dsebastien @SuperITMan @ncedric @RobbyDeLaet

If you agree, I will submit a PR for this ;)
@christophercr christophercr added the comp: stark-all To apply for all Stark modules label Apr 25, 2018
@christophercr christophercr added this to the 10.0.0-alpha.1 milestone Apr 25, 2018
@dsebastien
Copy link
Contributor

Great idea indeed

christophercr referenced this issue in christophercr/stark May 4, 2018
@christophercr
feat(stark-all): integrate SonarTS to current TSLint checks. Refactor…
2a64540 
… code to fix TSLint violations.

ISSUES CLOSED: #331
@christophercr christophercr mentioned this issue May 4, 2018
Merged
3 tasks
christophercr referenced this issue in christophercr/stark May 4, 2018
@christophercr
feat(stark-all): integrate SonarTS to current TSLint checks. Refactor…
6df6797 
… code to fix TSLint violations.

ISSUES CLOSED: #331
@dsebastien dsebastien added the P2 label May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: build-main Main build comp: qa comp: stark-all To apply for all Stark modules P2
Projects
None yet
Milestone
10.0.0-alpha.3
Development

No branches or pull requests
2 participants
@dsebastien @christophercr