Skip to content
This repository has been archived by the owner on May 8, 2023. It is now read-only.

Bug rxjs 6 is not set in Nativescript yet, latest should not require it #41

Open
ZachRoberts25 opened this issue May 23, 2018 · 4 comments

Comments

@ZachRoberts25
Copy link

Hey Guys,

The latest release requires rxjs 6. This causes a lot of problems with other plugins/libraries and even nativescript itself. You need to wait until nativescript releases its version that has rxjs 6 support.

Please make these changes to make this library useable again.

@ZachRoberts25 ZachRoberts25 changed the title Bug rxjs is not set in Nativescript yet, master should not require it Bug rxjs 6 is not set in Nativescript yet, latest should not require it May 23, 2018
@NathanWalker
Copy link
Owner

Can’t you just pin to older version of this lib?

@ZachRoberts25
Copy link
Author

You can, and that is how I solved it for myself. But you are now requiring everyone who wants to use it, to pin a recent version instead of just downloading it and they're off and running. It took me a while to solve this issue, so just wanted to prevent others from having to do the same. I would recommend going back down to rxjs 5.5 for now, until nativescript latest is on 6.0 as well.

@kvindascr
Copy link

+1 on this one.

When updating my app to tns4 I updated this plugin assuming it was a relatively low risk.
Then my whole app started to broke.
As I updated several things at once it was very difficult to track back what was causing the issue,

Basically I had a complain about document.createElement do not exists or something similar.

I have lost about one afternoon tracking down this problem, until I find out this post.

I do think updating the lib to rxjs to a non compatible version basically turns the release unusable.

@NathanWalker
Copy link
Owner

@ZachRoberts25 @kvindasAB apologies - I should have bumped major version to 5.0.0 when doing this instead of minor to 4.2 since it was a breaking change. We'll leave this open for rest of year.

Solution for folks is to pin to 4.1.0 if using anything below rxjs 6.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants