Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better split_into_n for chunkdivision #978

Closed
stevengj opened this issue Aug 1, 2019 · 0 comments · Fixed by #982
Closed

better split_into_n for chunkdivision #978

stevengj opened this issue Aug 1, 2019 · 0 comments · Fixed by #982

Comments

@stevengj
Copy link
Collaborator

stevengj commented Aug 1, 2019

It would be nice to replace the split_into_three function from #976 into a similar routine that splits into n for any n. Basically you just call find_best_split(n, ...), then find_best_split(n-1, ...) on the remaining chunk, then find_best_split(n-2, ...), and so on n-1 times.

This would also let us handle other prime factors (e.g. 5) more efficiently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant