-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
print more timing statistics #927
Conversation
Would be nice to verify that the standard deviation of the timing is related to load balancing. For example, you could try running the benchmark in #681, where we know that |
This seems to be working but the results for Running the unmodified example in #681 for the two cases and plotting the results (just the time-stepping portion of the simulation) is shown below. split_by_effort
split_by_cost
Note that the magnitude of the error bars for the " |
Anyway, it seems like the variance is doing what it is supposed to: it is larger in the case with poorer load-balancing. The surprise here is that |
for (int i = 0; i <= Other; ++i) { | ||
mean[i] /= n; | ||
stddev[i] -= n*mean[i]*mean[i]; | ||
stddev[i] = n == 1 || stddev[i] <= 0 ? 0.0 : sqrt(stddev[i] / (n-1)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that this is computing stddev =
∑(xᵢ-x̄)² / (n-1) = (∑xᵢ² - nx̄²) / (n-1)
* print more timing statistics * whoops
Closes #924.