From 9e0b9978eb9633eb281c87867b5a77dbde9efe54 Mon Sep 17 00:00:00 2001 From: jdkgabri Date: Sun, 1 May 2022 18:59:02 +0200 Subject: [PATCH] Updated notes and dummy changes to trigger discord --- .gitlab-ci.yml | 3 +++ .../core/main/code/lwc/showToastUtility/showToastUtility.js | 3 +-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index dca518a7..413ee83a 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -2,11 +2,14 @@ # .gitlab-ci.yml@jdkgabri/project-scaffolding-pipelines (separate repo with just gitlab-ci.yml and pipeline .yml files) # https://raw.githubusercontent.com/Nakama-Partnering-Services/project-scaffolding/main/.gitlab-ci.yml +# TODO: Try to run pipelines for external pull requests in GitHub: https://docs.gitlab.com/ee/ci/ci_cd_for_external_repos/index.html#pipelines-for-external-pull-requests + # TODO: Try gitlab-ci.yml on same repo, but trigger pipelines from another private project on the same GitLab instance, # so that pipelines logic remains more private and protected, but members do not have access problems. # Variables for manual-deploment. Some variable referenced in job rules, although empty, # they exist since they are declared here, so we need to check emptyness specifically + variables: DESTINATION_ENVIRONMENT: value: '' diff --git a/sfdx-source/core/main/code/lwc/showToastUtility/showToastUtility.js b/sfdx-source/core/main/code/lwc/showToastUtility/showToastUtility.js index aa2c9d57..e030dadb 100644 --- a/sfdx-source/core/main/code/lwc/showToastUtility/showToastUtility.js +++ b/sfdx-source/core/main/code/lwc/showToastUtility/showToastUtility.js @@ -1,8 +1,7 @@ /* eslint-disable no-console */ /** - * Toast notification handler + * A Toast notification handler */ - import { ShowToastEvent } from 'lightning/platformShowToastEvent'; /** * Shows a success toast notification