Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review ideas: logging instead of print statements #13

Open
ghost opened this issue Jul 26, 2016 · 1 comment
Open

Code review ideas: logging instead of print statements #13

ghost opened this issue Jul 26, 2016 · 1 comment

Comments

@ghost
Copy link

ghost commented Jul 26, 2016

wavetrace is great for batch processing, however it's tough to import into another project and call the methods, returning the result you need.

There are a few things that could make this easier - without making the batch processing harder, so i'll note these ideas one-per-issue;
This one is logging.

Logging instead of print statements would make it much easier for a consuming project to handle the output. Logging also makes it easy to see where and when (even what line no.) a logging call is being made from, plus you can crank up the logging level with one line change, and drop it back after you find and fix the problem.

@jamiesgithub
Copy link

I agree. The original use case was straight batch processing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant