Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Big "LANDMARK" text at top of lot profile is distracting #926

Open
hannahkates opened this issue Jul 16, 2019 · 4 comments · May be fixed by #1030
Open

Big "LANDMARK" text at top of lot profile is distracting #926

hannahkates opened this issue Jul 16, 2019 · 4 comments · May be fixed by #1030
Labels
User Feedback Feedback provided by a user

Comments

@hannahkates
Copy link
Contributor

A user has complained that it's distracting to see the large "LANDMARK" header at the very top of the profile, since they are most interested in the address. Screenshot below for context.

We are intentionally adding this to the profile; it doesn't come in the address data field. It's unclear why it was decided to label the record this way.

image
@allthesignals
Copy link
Collaborator

@andycochran any recollection on whether there was some good reason for this? It appears to show this property, "landmark", explicitly in the lot view: https://github.com/NYCPlanning/labs-zola/blob/develop/app/templates/components/layer-record-views/tax-lot.hbs#L14-L18

Is this intended to be placeholder for more description? Like Empire State Building or something?

@hannahkates hannahkates added the User Feedback Feedback provided by a user label Mar 17, 2020
@allthesignals
Copy link
Collaborator

Not sure what the fix for this should be. Should it not show "INDIVIDUAL LANDMARK" if that's all it says?

@allthesignals
Copy link
Collaborator

Doing some digging... originally, it preferred showing landmark if available:

26bc0a3#diff-d14dcb7eda6987a697beabdd980010cae38b178231b2ed5198f6b26e06594979R8-R13

Maybe the landmark field changed in newer versions of PLUTO?

Here's a breakdown of the variety of that field:
"INDIVIDUAL AND INTERIOR LANDMARK","count":92
"INDIVIDUAL LANDMARK","count":1321
"INTERIOR LANDMARK","count":28
"landmark":null,"count":855788

Naturally, most are null. It seems like when not null, though, it doesn't provide a whole lot of information and probably shouldn't be front and center.

@allthesignals allthesignals linked a pull request Oct 27, 2021 that will close this issue
Open
@allthesignals
Copy link
Collaborator

New PR does this:

image

No "landmark" field value:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
User Feedback Feedback provided by a user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Swap visual hierarchy bt address and landmark in tax-lot view allthesignals/labs-zola
2 participants
@allthesignals @hannahkates