Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is a full game dump (RomFS) required? #22

Closed
sSomename opened this issue May 30, 2023 · 2 comments
Closed

Why is a full game dump (RomFS) required? #22

sSomename opened this issue May 30, 2023 · 2 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers wontfix This will not be worked on

Comments

@sSomename
Copy link

sSomename commented May 30, 2023 •
edited
Loading

Why is the romfs required to edit files. Unlike a mod manager which has clear reasons for such a requirement this is a tool for editing files from the game.
@ArchLeaders
Copy link
Member

Every file that is compressed with zStandard (.zs) requires a dictionary file (ZsDic.pack.zs) to decompress. But, since you would need to dump the game to get those files anyway, and with future developments in mind to use more files. It seemed sensible to require a full game dump just for simplicity.

At any rate, you'll need it eventually for a mod merger.

@ArchLeaders ArchLeaders closed this as not planned Won't fix, can't repro, duplicate, stale May 30, 2023
@ArchLeaders ArchLeaders added documentation Improvements or additions to documentation good first issue Good for newcomers wontfix This will not be worked on labels May 30, 2023
@ArchLeaders ArchLeaders changed the title romfs requirement? Why is a full game dump (RomFS) required? May 30, 2023
@ArchLeaders ArchLeaders pinned this issue May 30, 2023
@sSomename
Copy link
Author

Thanks for the quick and clear explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sSomename @ArchLeaders