-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
why the mean_t and std_t for 7-Scenes are set to zeros(3) and ones(3) in SevenScenes dataset? #35
Comments
Hi @ZhouJiaHuan. IIRC the |
Thanks for your replying. @samarth-robo Yea, because my environment is Python3 + PyTorch 1.5.1, I modified some codes for compatibility and then trained first with all the default parameters (including the identity pose stats). The val result is almost same with the paper. The experimental result is as follows:
I am not sure whether the different PyTorch version will affect the result a lot. (the pretrained weights of ResNet-34 in Torch 1.5.1 is different with that in Torch 0.4.1) However, when I substitute the identity pose stats with the value computed from
And as a reference, I also visualize the training process with TensorboardX The figure above is the learning parameters in MapNet loss function and the figure below is the training/val loss. As you see, the learning parameters are almost same during training pipeline. But the training loss for computed pose stats (in blue) seems not converge well. |
@ZhouJiaHuan OK. And just to confirm, you calculated pose stats similarly to RobotCar, by modifying L100 and L101 of
|
@samarth-robo That's my code to calculate pose stats.
the code below is equivalent to that in RobotCar:
|
@samarth-robo hey, I found the causes. It's my inference codes problem. I forgot to change the pose stats during inference phase so that the pose stats is still the identity. I fixed this error and the error for mapnet on |
@ZhouJiaHuan I was just about to comment that! Glad you found the solution. I'll close this issue now. |
Hey, I noticed that the pose stats of 7-Scenes, namely the mean_t and std_t are simply set to zeros(3) and ones(3). But when I use the pose stats computed by myself (not equal to zeros(3) and ones(3)) for training and evaluation, the accuracy decreased a lot.
The text was updated successfully, but these errors were encountered: