Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Documentation of thrust::for_each erroneously uses std::device_vector #1529

Closed
sdall opened this issue Sep 23, 2021 · 4 comments · Fixed by #1539
Closed

Documentation of thrust::for_each erroneously uses std::device_vector #1529

sdall opened this issue Sep 23, 2021 · 4 comments · Fixed by #1539
Labels
good first issue Good for newcomers. hacktoberfest-accepted Marks an accepted PR for hacktoberfest. only: docs Documentation changes only. Doesn't need code CI. P1: should have Necessary, but not critical.

Comments

@sdall
Copy link

sdall commented Sep 23, 2021

thrust/for_each.h:58 contains "a \p std::device_vector" rather than "a \p thrust::device_vector".

@alliepiper alliepiper added P1: should have Necessary, but not critical. only: docs Documentation changes only. Doesn't need code CI. good first issue Good for newcomers. labels Sep 23, 2021
@fla-t
Copy link
Contributor

fla-t commented Oct 12, 2021

Plus can you also add the "hacktoberfest-accepted" tag/label. Thanks!

@alliepiper
Copy link
Collaborator

@untamedimpala I added the tag here too -- I'm not very familiar with how hackoberfest works 😅 Does the tag usually go on the PR or the issue, or does it matter?

@fla-t
Copy link
Contributor

fla-t commented Oct 20, 2021

@untamedimpala I added the tag here too -- I'm not very familiar with how hackoberfest works 😅 Does the tag usually go on the PR or the issue, or does it matter?

No, it goes to the issue, which you did right in the first place. My bad I didn't checked that you had already added the tag. Sorry.

@alliepiper
Copy link
Collaborator

Sounds good. Not a problem, just want to make sure it's marked up correctly for ya :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers. hacktoberfest-accepted Marks an accepted PR for hacktoberfest. only: docs Documentation changes only. Doesn't need code CI. P1: should have Necessary, but not critical.
Projects
None yet
3 participants