Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Binary search can fail due to overflow error #1305

Closed
r-barnes opened this issue Oct 7, 2020 · 2 comments · Fixed by #1306
Closed

Binary search can fail due to overflow error #1305

r-barnes opened this issue Oct 7, 2020 · 2 comments · Fixed by #1306
Assignees
@r-barnes
Labels
type: bug: functional Does not work as intended.
Milestone
1.11.0

Comments

@r-barnes
Copy link
Contributor

r-barnes commented Oct 7, 2020

The binary search implementation suffers from a well-known issue that can lead to incorrect results on large datasets. This happens here and here. There's a simple fix which I'll provide a PR for.
@r-barnes r-barnes mentioned this issue Oct 7, 2020
Merged
@alliepiper alliepiper added this to the 1.11.0 milestone Oct 12, 2020
@alliepiper alliepiper added the type: bug: functional Does not work as intended. label Oct 12, 2020
@alliepiper alliepiper linked a pull request Oct 12, 2020 that will close this issue
Fix binary search middle calculation to avoid overflows #1306
Merged
@r-barnes
Copy link
Contributor Author

@allisonvacanti, #1306 has been approved for merge, which resolves this bug. Not sure how that should be handled on your end.

@r-barnes
Copy link
Contributor Author

Oh, nevermind, I see that you're on that thread too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@r-barnes r-barnes

Labels
type: bug: functional Does not work as intended.
Projects
None yet
Milestone
1.11.0
Development

Successfully merging a pull request may close this issue.

Fix binary search middle calculation to avoid overflows r-barnes/thrust
2 participants
@alliepiper @r-barnes