Split batch by key for window operations #2458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <[email protected]>
|
Switched to draft. I found a bug in cudf while adding the tests and I want to fix it before adding the tests. I also have a new idea on how to get the framework to insert the chunking only when needed and I want to work on that too. |
|
I added tests and fixed some issues, including #2473 But if found a bug in cudf as a part of the tests so this is also blocked by rapidsai/cudf#8314 |
|
I am going to move the test fixes to another PR, and then move this to the next release, and I don't think the benefit is worth the added risk right now. |
Signed-off-by: Robert (Bobby) Evans <[email protected]>
|
build |
|
This is actually waiting for a new branch because it is a bit too risky for 21.06 |
|
build |
|
build |
jlowe
reviewed
Jun 2, 2021
sql-plugin/src/main/java/com/nvidia/spark/rapids/GpuColumnVector.java
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/java/com/nvidia/spark/rapids/GpuColumnVectorBase.java
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuCoalesceBatches.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuCoalesceBatches.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuKeyBatchingIterator.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuKeyBatchingIterator.scala
Show resolved
Hide resolved
|
build |
|
@jlowe I have addressed your comments please take another look |
jlowe
previously approved these changes
Jun 3, 2021
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuKeyBatchingIterator.scala
Show resolved
Hide resolved
|
build |
jlowe
approved these changes
Jun 3, 2021
tgravescs
pushed a commit
that referenced
this pull request
Jun 9, 2021
Signed-off-by: Robert (Bobby) Evans <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1856
It makes it so that window operations do not need a
RequireSingleBatchfor anything except when there is no partitioning. This allows us to do window operations where there are a lot of keys, but more data than fits on the GPU. I have not updated the tests yet. I'll post that shortly, but I have done manual testing on very large data sets and it has essentially no performance impact on queries that do fit in GPU memory.