Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Add AST for safe upcasts #9645

Open
revans2 opened this issue Nov 6, 2023 · 0 comments
Open

[FEA] Add AST for safe upcasts #9645

revans2 opened this issue Nov 6, 2023 · 0 comments
Labels
feature request New feature or request good first issue Good for newcomers

Comments

@revans2
Copy link
Collaborator

revans2 commented Nov 6, 2023

Is your feature request related to a problem? Please describe.
Recently I was playing around with #9635 and hit a situation where an int was auto upcast to a long. This was enough to make the join fall back to the CPU. This is a little frustrating when casting an int to a long should be totally safe and supported by AST already.

https://github.com/rapidsai/cudf/blob/70c4283dbd6700bba43440e07b293b2294ea6634/java/src/main/java/ai/rapids/cudf/ast/UnaryOperator.java#L50-L52

Describe the solution you'd like
I would like to see us have the ability to support safe casts from byte, short, and int to INT64 as this should always be safe. I would also love to see us casting from float32 to a float64 as that too should be safe.

@revans2 revans2 added feature request New feature or request ? - Needs Triage Need team to review and classify labels Nov 6, 2023
@mattahrens mattahrens added good first issue Good for newcomers and removed ? - Needs Triage Need team to review and classify labels Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants