Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] bround and round do not return the correct result for some decimal values. #9309

Closed
revans2 opened this issue Sep 27, 2023 · 2 comments · Fixed by #9351
Closed

[BUG] bround and round do not return the correct result for some decimal values. #9309

revans2 opened this issue Sep 27, 2023 · 2 comments · Fixed by #9351
Assignees
@revans2
Labels
bug Something isn't working cudf_dependency An issue or PR with this label depends on a new feature in cudf

Comments

@revans2
Copy link
Collaborator

revans2 commented Sep 27, 2023

Describe the bug
As a part of testing format_number I discovered that bround, which does half even rounding, is returning the wrong value for some decimal inputs.

A decimal(38,37) with the value 0.0312500000000000000000000000000000000 when you bround it to 4 places will return 0.0312 on the GPU, but 0.0313 on the CPU. The CPU version is correct because 5 rounds up.

This just calls directly into CUDF so I think this is actually a bug in CUDF. I'll try to come up with a repro case there and file an issue.
@revans2 revans2 added bug Something isn't working ? - Needs Triage Need team to review and classify labels Sep 27, 2023
@revans2 revans2 changed the title [BUG] bround does not return the correct result for some decimal values. [BUG] bround and round do not return the correct result for some decimal values. Sep 27, 2023
@revans2
Copy link
Collaborator Author

revans2 commented Sep 27, 2023

rapidsai/cudf#14210

@revans2 revans2 added the cudf_dependency An issue or PR with this label depends on a new feature in cudf label Sep 27, 2023
@firestarman firestarman mentioned this issue Sep 28, 2023
Merged
@thirtiseven thirtiseven mentioned this issue Sep 28, 2023
Closed
@revans2 revans2 self-assigned this Sep 29, 2023
@revans2 revans2 mentioned this issue Sep 29, 2023
Merged
@revans2
Copy link
Collaborator Author

revans2 commented Oct 3, 2023

The CUDF bug was just merged. By tomorrow Oct 4th we should have a build with the fix in it.

@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@revans2 revans2

Labels
bug Something isn't working cudf_dependency An issue or PR with this label depends on a new feature in cudf
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Put back in full decimal support for format_number revans2/spark-rapids
2 participants
@revans2 @mattahrens