Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Add retry to GpuShuffleCoalesceExec #8501

Closed
abellina opened this issue Jun 5, 2023 · 2 comments
Closed

[FEA] Add retry to GpuShuffleCoalesceExec #8501

abellina opened this issue Jun 5, 2023 · 2 comments
Labels
duplicate This issue or pull request already exists feature request New feature or request reliability Features to improve reliability or bugs that severly impact the reliability of the plugin

Comments

@abellina
Copy link
Collaborator

abellina commented Jun 5, 2023

Is your feature request related to a problem? Please describe.
We do not support retry in GpuShuffleCoalesceExec. We should be able to easily support retry.
@abellina abellina added feature request New feature or request ? - Needs Triage Need team to review and classify reliability Features to improve reliability or bugs that severly impact the reliability of the plugin labels Jun 5, 2023
@abellina abellina mentioned this issue Jun 5, 2023
Open
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Jun 7, 2023
@firestarman
Copy link
Collaborator

firestarman commented Sep 7, 2023 •
edited
Loading

Seems GpuShuffleCoalesceExec already supports retry. According to the following call stack, we have already added retry support in HostConcatResultUtil.getColumnarBatch.

GpuShuffleCoalesceExec
-> GpuShuffleCoalesceIterator
   -> HostConcatResultUtil.getColumnarBatch

@abellina Could you help confirm this ?

@abellina
Copy link
Collaborator Author

abellina commented Sep 7, 2023

@firestarman, I am sorry I think you are right. Looking back at the report, it was for 23.08 but the line numbers aren't matching with what we have in HostConcatResultUtil. It looks like this was resolved in #8009. I'll close this!

@abellina abellina closed this as completed Sep 7, 2023
@sameerz sameerz added the duplicate This issue or pull request already exists label Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists feature request New feature or request reliability Features to improve reliability or bugs that severly impact the reliability of the plugin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@abellina @mattahrens @sameerz @firestarman