Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Update documentation about assertion for non-empty nulls #8238

Closed
razajafri opened this issue May 5, 2023 · 1 comment
Closed

[DOC] Update documentation about assertion for non-empty nulls #8238

razajafri opened this issue May 5, 2023 · 1 comment
Assignees
@razajafri
Labels
documentation Improvements or additions to documentation

Comments

@razajafri
Copy link
Collaborator

Report needed documentation

Report needed documentation
The spark-rapids-jni jar will throw an AssertionError if data contains non-emtpy nulls. This needs to be reflected in the documentation

Describe the documentation you'd like
Inform the users that cudf will report incorrect results if the data contains non-empty nulls, but if they still want to proceed with the same data they should disable asserts by -da:ai.rapids.cudf.AssertEmptyNulls
@razajafri razajafri added documentation Improvements or additions to documentation ? - Needs Triage Need team to review and classify labels May 5, 2023
@razajafri razajafri self-assigned this May 5, 2023
@razajafri razajafri added the P0 Must have for release label May 5, 2023
@mattahrens mattahrens changed the title [DOC] Update documentaion about assertion for non-emtpy nulls [DOC] Update documentation about assertion for non-empty nulls May 9, 2023
@mattahrens mattahrens removed ? - Needs Triage Need team to review and classify P0 Must have for release labels May 9, 2023
@razajafri razajafri mentioned this issue May 10, 2023
Closed
@razajafri
Copy link
Collaborator Author

This issue is not required as assertions are disabled by default in Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@razajafri razajafri

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added documentation for assertion on non-empty nulls [skip ci] razajafri/spark-rapids
2 participants
@mattahrens @razajafri