Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Remainder[DecimalType] for Spark 3.4 and DB 11.3 #8161

Closed
razajafri opened this issue Apr 20, 2023 · 0 comments · Fixed by #8302
Closed

Add support for Remainder[DecimalType] for Spark 3.4 and DB 11.3 #8161

razajafri opened this issue Apr 20, 2023 · 0 comments · Fixed by #8302
Assignees
@NVnavkumar
Labels
bug Something isn't working Spark 3.4+ Spark 3.4+ issues

Comments

@razajafri
Copy link
Collaborator

Describe the bug
As part of #7609 DecimalType support for Remainder was taken out.

Steps/Code to reproduce bug
Run test_mod for Spark 3.4 (it's skipped right now) or other tests that use Remainder. The test will fail for DecimalTypes.

Expected behavior
The test should pass for Decimal values. Revert changes made specifically for disabling support for #7609. Note that this isn't going to be a clean revert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NVnavkumar NVnavkumar

Labels
bug Something isn't working Spark 3.4+ Spark 3.4+ issues
Projects
None yet
Milestone
No milestone
4 participants
@mattahrens @razajafri @rwlee @NVnavkumar