-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Add string comparison to AST expressions #8157
Comments
Since one customer hit the same fallback, just posted a reproduction here:
fallback info:
CC @viadea |
This is not super simple to do with just AST. CUDF AST supports string comparisons, but it does not support trim or lower, and because those would need to allocate GPU memory to support the temporary output it is unlikely that we would ever be able to support it. So to make this work we would have to rewrite the query to be something like
So this one feature is not going to be enough to support the example query. I'll file an issue for this. |
rapidsai/cudf#13072 adds Java bindings for string literals and string comparisons to AST expressions. We should extend the RAPIDS Accelerator functionality to leverage this in AST expressions which may appear in join conditions.
The text was updated successfully, but these errors were encountered: