Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] reduce retry window for Project #7868

Open
revans2 opened this issue Mar 9, 2023 · 0 comments
Open

[FEA] reduce retry window for Project #7868

revans2 opened this issue Mar 9, 2023 · 0 comments
Labels
performance A performance related task/issue reliability Features to improve reliability or bugs that severly impact the reliability of the plugin

Comments

@revans2
Copy link
Collaborator

revans2 commented Mar 9, 2023

Is your feature request related to a problem? Please describe.
Once #7864 and #7672 are done it would be very nice to have the ability to reduce what is retried when processing a project operation. Right now if a project fails all of the expressions will be re-evaluated. This is done because it is expensive to make the completed work spillable. But #7672 should solve that cost problem.

The goal of this would be to make the result of each expressions spillable as soon as it completes and save it away so if we have to retry an operation we only have to retry what was not completed. I don't know if this is actually going to be a performance win or not. We should do some performance tests once a prototype is ready because it might be more expensive to spill/unspill the result, than it would be to re-calculate it. I think on average it is likely to be a win, but we need to test this.

If it does look like it is not a win, then perhaps we can see if a heuristic would help. Something like doing a checkpoint if the computation rate is slower than the PCIe spill rate would be.

@revans2 revans2 added feature request New feature or request ? - Needs Triage Need team to review and classify performance A performance related task/issue reliability Features to improve reliability or bugs that severly impact the reliability of the plugin labels Mar 9, 2023
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Mar 21, 2023
@sameerz sameerz removed the feature request New feature or request label Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance A performance related task/issue reliability Features to improve reliability or bugs that severly impact the reliability of the plugin
Projects
None yet
Development

No branches or pull requests

4 participants