Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Check that thread active in cuDF is holding onto the semaphore in the tests #7742

Open
abellina opened this issue Feb 13, 2023 · 0 comments
Labels
reliability Features to improve reliability or bugs that severly impact the reliability of the plugin

Comments

@abellina
Copy link
Collaborator

With the work we are doing #7252 we need to make sure we are consistently grabbing the semaphore before calling into cuDF (and also when we are holding non-spillable memory).

We would like to add assertions that trigger in the tests where if a thread is known to be doing work on the GPU that it must be holding onto the semaphore, otherwise the concurrentGpuTasks config doesn't work in all cases.

This came about because of #7729, where the semaphore debug logic caught multiple threads doing exactly this.

@abellina abellina added feature request New feature or request ? - Needs Triage Need team to review and classify reliability Features to improve reliability or bugs that severly impact the reliability of the plugin labels Feb 13, 2023
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Feb 14, 2023
@sameerz sameerz added ? - Needs Triage Need team to review and classify and removed feature request New feature or request ? - Needs Triage Need team to review and classify labels Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reliability Features to improve reliability or bugs that severly impact the reliability of the plugin
Projects
None yet
Development

No branches or pull requests

3 participants