Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] currentSpillableSize could cause OOM #7706

Open
abellina opened this issue Feb 8, 2023 · 0 comments
Open

[BUG] currentSpillableSize could cause OOM #7706

abellina opened this issue Feb 8, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@abellina
Copy link
Collaborator

abellina commented Feb 8, 2023

The current check for currentSpillableSize where we want to make sure the store's spillable count is above the target size, can prevent us from spilling anything and makes big assumptions that what is in the store is not contributing to fragmentation.

We do not want to check currentSpillableSize at all, and instead we want to just spill at least one buffer and let the allocation retry (per @jlowe's comment here: #7572 (comment)).

Note that we also want to look at prioritizing the spillables based on size: #7705, which is related to the heuristic here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants