Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Regression in NDSv2 of 4% because of spillable broadcast #6708

Closed
abellina opened this issue Oct 5, 2022 · 0 comments · Fixed by #6709
Closed

[BUG] Regression in NDSv2 of 4% because of spillable broadcast #6708

abellina opened this issue Oct 5, 2022 · 0 comments · Fixed by #6709
Assignees
Labels
P0 Must have for release performance A performance related task/issue

Comments

@abellina
Copy link
Collaborator

abellina commented Oct 5, 2022

We found a regression of ~4% for our NDSv2 benchmark in our performance cluster after this change went in: #6604

The issue is we are acquiring the semaphore too early, before the stream side has materialized the first batch. So this means that if the first stream batch requires data from say a data source (like a parquet table), we'd hold the semaphore while we do all of the IO to materialize the stream side, this is not ideal. The issue is very similar to what was fixed here: #4539, and so the proposed fix is very similar, just for broadcasts.

@abellina abellina added bug Something isn't working ? - Needs Triage Need team to review and classify labels Oct 5, 2022
@abellina abellina added this to the Sep 26 - Oct 7 milestone Oct 5, 2022
@abellina abellina self-assigned this Oct 5, 2022
@abellina abellina added the P0 Must have for release label Oct 5, 2022
@sameerz sameerz added performance A performance related task/issue and removed ? - Needs Triage Need team to review and classify bug Something isn't working labels Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Must have for release performance A performance related task/issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants