Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Audit regexp/cast code to see if we can use more non-capture groups #6470

Open
andygrove opened this issue Aug 31, 2022 · 1 comment
Open
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf performance A performance related task/issue

Comments

@andygrove
Copy link
Contributor

Is your feature request related to a problem? Please describe.
#6468 is a good example of a simple optimization by using non-capture groups instead of capture groups in a regexp call. We should see if there are other places where we can do this (I'm certain there are plenty of examples in the GpuCast code).

Describe the solution you'd like
Audit the code and use non-capture groups where possible.

Describe alternatives you've considered
None

Additional context
None

@andygrove andygrove added feature request New feature or request ? - Needs Triage Need team to review and classify labels Aug 31, 2022
@sameerz sameerz added performance A performance related task/issue cudf_dependency An issue or PR with this label depends on a new feature in cudf and removed feature request New feature or request ? - Needs Triage Need team to review and classify labels Sep 7, 2022
@sameerz
Copy link
Collaborator

sameerz commented Sep 12, 2022

Related cudf issue rapidsai/cudf#11663

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf performance A performance related task/issue
Projects
None yet
Development

No branches or pull requests

2 participants