Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Replace post-round cast over decimal round #5803

Closed
sperlingxx opened this issue Jun 13, 2022 · 2 comments
Closed

[FEA] Replace post-round cast over decimal round #5803

sperlingxx opened this issue Jun 13, 2022 · 2 comments
Labels
performance A performance related task/issue wontfix This will not be worked on

Comments

@sperlingxx
Copy link
Collaborator

sperlingxx commented Jun 13, 2022

Is your feature request related to a problem? Please describe.
This is a follow-up issue of #5766 and #5786. Post-round casts are conducted over decimal rounds to fit the output precision and scale: code1 code2 .

Describe the solution you'd like
They are sort of workaround, which can be replaced by cuDF built-in support.

@sperlingxx sperlingxx added feature request New feature or request ? - Needs Triage Need team to review and classify labels Jun 13, 2022
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Jun 14, 2022
@jlowe
Copy link
Member

jlowe commented Jun 14, 2022

cudf will short-circuit the cast if the cast ends up being a no-op (e.g.: DECIMAL64 -> DECIMAL64). As such this is relatively minor and would only be a real cast in the case where the pre-cast for round ends up crossing a precision boundary (e.g.: DECIMAL32 -> DECIMAL64).

@jlowe jlowe added performance A performance related task/issue and removed feature request New feature or request labels Jun 14, 2022
@jlowe
Copy link
Member

jlowe commented Jun 14, 2022

Closing this as wont fix for now, this is likely not getting fixed in cudf and performance impact is likely negligible.

@jlowe jlowe closed this as completed Jun 14, 2022
@sameerz sameerz added the wontfix This will not be worked on label Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance A performance related task/issue wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants