You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The changes in #5610 add very broad checks for patterns containing end of line anchor $ immediately next to a newline, begin-of-line anchor ^ or repetition that could produce empty results. However, this results in false positives:
$ and ^ inside character classes are being treated as anchors, eg. the pattern 0*[D$3] has no string anchors but will still fallback to CPU.
We are checking the entire AST node before/after a $, meaning something like \na$ is allowed, but (\na)$ will fallback to CPU. We should instead check only the component in the group that is closest to the $.
We fallback to CPU for cases such as ^([a-z]*)([0-9]*)([a-z]*)$ which have no line terminator characters.
Steps/Code to reproduce bug
Test with the above examples.
Expected behavior
We should support these cases on GPU, and they should be consistent with CPU
Environment details (please complete the following information)
N/A
Additional context
None.
The text was updated successfully, but these errors were encountered:
Describe the bug
The changes in #5610 add very broad checks for patterns containing end of line anchor
$
immediately next to a newline, begin-of-line anchor^
or repetition that could produce empty results. However, this results in false positives:$
and^
inside character classes are being treated as anchors, eg. the pattern0*[D$3]
has no string anchors but will still fallback to CPU.$
, meaning something like\na$
is allowed, but(\na)$
will fallback to CPU. We should instead check only the component in the group that is closest to the$
.^([a-z]*)([0-9]*)([a-z]*)$
which have no line terminator characters.Steps/Code to reproduce bug
Test with the above examples.
Expected behavior
We should support these cases on GPU, and they should be consistent with CPU
Environment details (please complete the following information)
N/A
Additional context
None.
The text was updated successfully, but these errors were encountered: