Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Investigate more edge cases in regexp support #5525

Closed
andygrove opened this issue May 18, 2022 · 0 comments · Fixed by #5610
Closed

[BUG] Investigate more edge cases in regexp support #5525

andygrove opened this issue May 18, 2022 · 0 comments · Fixed by #5610
Assignees
Labels
bug Something isn't working

Comments

@andygrove
Copy link
Contributor

Describe the bug
We have fuzz tests that are passing but through some experimentation I was able to make the fuzz tests generate previously unseen patterns and data and this exposes more edge cases where we are not consistent between CPU and GPU.

regexp_find examples

javaPattern=$x*\r, cudfPattern=(?:[\n\r\u0085\u2028\u2029]|\r\n)?$x*\r, input='\u000b.\r', cpu=true, gpu=false
javaPattern=\w[\r,B]\Z, cudfPattern=\w[\r,B](?:[\n\r\u0085\u2028\u2029]|\r\n)?$, input='D31b\r\n', cpu=false, gpu=true

regexp_replace examples

javaPattern=^$\s, cudfPattern=^([\n\r\u0085\u2028\u2029]|\r\n)?$[ \u000b\n\t\r\f], input='\n', cpu=_RE\PLACE_, gpu=\n
javaPattern=\s\Z\Z, cudfPattern=[ \u000b\n\t\r\f]([\n\r\u0085\u2028\u2029]|\r\n)?$, input='w\f\n', cpu=w_RE\PLACE__RE\PLACE_, gpu=w_RE\PLACE_\n

Steps/Code to reproduce bug
Add one or more extra character to RegularExpressionTranspilerSuiteREGEXP_LIMITED_CHARS_COMMON and run the existing tests.

Expected behavior
No failures.

Environment details (please complete the following information)
N/A

Additional context
None

@andygrove andygrove added bug Something isn't working ? - Needs Triage Need team to review and classify labels May 18, 2022
@andygrove andygrove added this to the May 2 - May 20 milestone May 18, 2022
@andygrove andygrove self-assigned this May 18, 2022
@anthony-chang anthony-chang self-assigned this May 19, 2022
@andygrove andygrove removed their assignment May 20, 2022
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants