Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] run integration tests without spark-avro jar in the classpath #4984

Closed
wbo4958 opened this issue Mar 18, 2022 · 3 comments
Closed

[FEA] run integration tests without spark-avro jar in the classpath #4984

wbo4958 opened this issue Mar 18, 2022 · 3 comments
Labels
test Only impacts tests

Comments

@wbo4958
Copy link
Collaborator

wbo4958 commented Mar 18, 2022

This is a follow up of #4956

PR 4956 introduced spark-avro jar in the test classpath, so every time when running integration tests, spark-avro jar will be involved which will be OK for avro test cases. But in fact, users may not include spark-avro in their user case, if some spark-avro code is involved by accident, then rapids plugin will throw exceptions.

So we need to add some checks to run integration tests without spark-avro jar to ensure no spark-avro code is involved. See the comments

@wbo4958 wbo4958 added feature request New feature or request ? - Needs Triage Need team to review and classify labels Mar 18, 2022
@GaryShen2008
Copy link
Collaborator

Shall we run the avro test cases of integration test separately? So that only avro test cases require to add spark-avro.jar, and the others run without it.

@wbo4958
Copy link
Collaborator Author

wbo4958 commented Mar 19, 2022

good point, that seems doable

@wbo4958
Copy link
Collaborator Author

wbo4958 commented Mar 22, 2022

This is added in the #4956. So just close this issue

@wbo4958 wbo4958 closed this as completed Mar 22, 2022
@sameerz sameerz added test Only impacts tests and removed feature request New feature or request ? - Needs Triage Need team to review and classify labels Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

No branches or pull requests

3 participants