Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Plugin will crash with query > 100 columns on pascal GPU #4739

Closed
hyperbolic2346 opened this issue Feb 9, 2022 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@hyperbolic2346
Copy link
Collaborator

Describe the bug
When 8444 was added to cuDF to support larger table conversion on the GPU, it added a dependency on hardware version > Pascal. The original design was for cuDF to crash and the plugin to detect this crash and fallback to the CPU for the conversion. This wasn't communicated clearly and the resulting fallback isn't implemented in the plugin, resulting in a crash. No data corruption, it simply won't work.

Steps/Code to reproduce bug
Run query with 22.02 plugin on a Pascal architecture GPU against a table with > 100 columns.

Expected behavior
The plugin continues to function, with or without gpu conversion of the data.

Additional context
The ultimate fix is to probably include Pascal compatible code in cuDF to handle the conversion on either side. This wouldn't be difficult to write as it can be a shim. This isn't something that can be handled in the 22.02 or 22.04 timeframe though.

@revans2
Copy link
Collaborator

revans2 commented Feb 9, 2022

I personally think that this is unlikely to show up in practice, but it would be something good to fix for 22.04

@sameerz
Copy link
Collaborator

sameerz commented Feb 9, 2022

Given the low likelihood of > 100 columns in a dataset and that this only impacts Pascal, I am ok moving this to 22.04.

@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Feb 15, 2022
@mythrocks mythrocks self-assigned this Feb 25, 2022
@mythrocks
Copy link
Collaborator

The ultimate fix is to probably include Pascal compatible code in cuDF to handle the conversion on either side.

We did this in #10329. This should be resolved now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants