Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Inconsistencies in handling of newline characters and string and line anchors #4521

Closed
andygrove opened this issue Jan 13, 2022 · 0 comments · Fixed by #4530
Closed
Assignees
Labels
bug Something isn't working

Comments

@andygrove
Copy link
Contributor

andygrove commented Jan 13, 2022

Describe the bug
Although we have implemented transpiler logic to correctly rewrite patterns for cuDF for many cases, we still do not cover all cases, and adding \r and \n to the set of characters we use for fuzzing causes test failures.

This is quite a broad issue and will likely be split into multiple issues once more analysis has been done.

Steps/Code to reproduce bug
Add \r\n to the REGEXP_LIMITED_CHARS_COMMON constant in RegularExpressionTranspilerSuite and run the tests.

Expected behavior
Test should pass and we should fall back to CPU for anything that we cannot support correctly.

Environment details (please complete the following information)
N/A

Additional context
None

@andygrove andygrove added bug Something isn't working ? - Needs Triage Need team to review and classify labels Jan 13, 2022
@andygrove andygrove self-assigned this Jan 14, 2022
@andygrove andygrove added this to the Jan 10 - Jan 28 milestone Jan 14, 2022
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants