Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Support idx = 0 in GpuRegExpExtract #4284

Closed
andygrove opened this issue Dec 3, 2021 · 2 comments · Fixed by #4285
Closed

[FEA] Support idx = 0 in GpuRegExpExtract #4284

andygrove opened this issue Dec 3, 2021 · 2 comments · Fixed by #4285
Assignees
@andygrove
Labels
feature request New feature or request
Milestone
Dec 13 - Jan 7

Comments

@andygrove
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The initial implementation of GpuRegExpExtract in #4002 will only support an idx that is greater than 0 (extract a single group). This issue is to implement support for idx of 0 which has different semantics.

Describe the solution you'd like
Match Spark behavior.

Describe alternatives you've considered
None

Additional context
None
@andygrove andygrove added feature request New feature or request ? - Needs Triage Need team to review and classify labels Dec 3, 2021
@andygrove andygrove mentioned this issue Dec 3, 2021
Merged
@Salonijain27 Salonijain27 added cudf_dependency An issue or PR with this label depends on a new feature in cudf and removed ? - Needs Triage Need team to review and classify labels Dec 7, 2021
@andygrove andygrove removed the cudf_dependency An issue or PR with this label depends on a new feature in cudf label Dec 7, 2021
@andygrove
Copy link
Contributor Author

I have a working implementation and will have a PR up soon. There are no dependencies on cuDF for this one.

@andygrove andygrove mentioned this issue Dec 7, 2021
Closed
@andygrove andygrove self-assigned this Dec 7, 2021
@andygrove andygrove added this to the Nov 30 - Dec 10 milestone Dec 7, 2021
@andygrove andygrove linked a pull request Dec 13, 2021 that will close this issue
Add support for regexp_extract on the GPU #4285
Merged
@andygrove
Copy link
Contributor Author

This was implemented in #4285

@andygrove andygrove mentioned this issue Jan 12, 2022
Open
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andygrove andygrove

Labels
feature request New feature or request
Projects
None yet
Milestone
Dec 13 - Jan 7
3 participants
@andygrove @sameerz @Salonijain27