Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further separate GpuPartitioning from Partitioning #3733

Open
jlowe opened this issue Oct 1, 2021 · 0 comments
Open

Further separate GpuPartitioning from Partitioning #3733

jlowe opened this issue Oct 1, 2021 · 0 comments
Labels
P1 Nice to have for release task Work required that improves the product but is not user facing

Comments

@jlowe
Copy link
Contributor

jlowe commented Oct 1, 2021

#3719 updates method signatures to specify GpuPartitioning when a GPU partitioning argument is expected, but GpuPartitioning still derives from Partitioning. This let's the compiler catch cases where we're accidentally passing a CPU partitioning to something that expects a GPU partitioning. However these should be independent types so a compile error occurs if a GPU partitioning is passed to something expecting a CPU partitioning.
@jlowe jlowe added ? - Needs Triage Need team to review and classify task Work required that improves the product but is not user facing labels Oct 1, 2021
@jlowe jlowe mentioned this issue Oct 1, 2021
Merged
@sameerz sameerz added P1 Nice to have for release and removed ? - Needs Triage Need team to review and classify labels Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 Nice to have for release task Work required that improves the product but is not user facing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlowe @sameerz