Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] CastOpSuite and ParseDateTimeSuite failures spark 302 and others #3478

Closed
tgravescs opened this issue Sep 14, 2021 · 13 comments
Closed
Assignees
Labels
bug Something isn't working P0 Must have for release

Comments

@tgravescs
Copy link
Collaborator

Describe the bug
running unit tests against spark 3.0.2 and the CastOpSuite has some failures:

  • Cast from string to date using random inputs *** FAILED ***
    Mismatch casting string [12\rZ] to DateType. CPU: null; GPU: 0012-01-01 (CastOpSuite.scala:247)

  • Cast from string to date using random inputs with valid year prefix *** FAILED ***
    Mismatch casting string [2021-9:] to DateType. CPU: null; GPU: 2021-09-01 (CastOpSuite.scala:247)

  • Test all supported casts with in-range values *** FAILED ***
    Cast from StringType to DateType failed; ansi=false org.scalatest.exceptions.TestFaile

@tgravescs tgravescs added bug Something isn't working ? - Needs Triage Need team to review and classify P0 Must have for release labels Sep 14, 2021
@tgravescs
Copy link
Collaborator Author

there are also failures in ParseDateTimeSuite:

  • WITH DECIMALS: to_date yyyy-MM-dd *** FAILED ***
    Mismatch between CPU and GPU for the following rows:

    [- WITH DECIMALS: to_timestamp yyyy-MM-dd *** FAILED ***

@tgravescs tgravescs changed the title [BUG] CastOpSuite failures spark 302 [BUG] CastOpSuite and ParseDateTimeSuite failures spark 302 Sep 14, 2021
@tgravescs tgravescs changed the title [BUG] CastOpSuite and ParseDateTimeSuite failures spark 302 [BUG] CastOpSuite and ParseDateTimeSuite failures spark 302 and others Sep 14, 2021
@tgravescs
Copy link
Collaborator Author

looks like this fails on spark 3.0.1 as well

@abellina
Copy link
Collaborator

Just ran into this with mvn verify

@tgravescs
Copy link
Collaborator Author

something very weird because rolled back to yesterday and they still fail there

@andygrove
Copy link
Contributor

perhaps the random data generation changes somehow and we are hitting test cases we haven't seen before? I'll take a look

@andygrove
Copy link
Contributor

some of these failing tests do not use random data generation, so seems like something more build related somehow

@tgravescs
Copy link
Collaborator Author

its a change in cudf that causes this, I tried an older version and it works there.

Perhaps rapidsai/cudf#9173 this

@revans2
Copy link
Collaborator

revans2 commented Sep 14, 2021

It looks like rapidsai/cudf#9173 when into cudf and broke things. I am going to try and update the casing code to deal with this. It gives us some things that we want, and some things that we don't want all at once.

@revans2 revans2 self-assigned this Sep 14, 2021
@revans2
Copy link
Collaborator

revans2 commented Sep 14, 2021

If someone else wants to disable those tests in the short term to unblock others I am fine with that.

@tgravescs
Copy link
Collaborator Author

working on disabling tests temporarily

@revans2
Copy link
Collaborator

revans2 commented Sep 14, 2021

Moved to @andygrove because he has been working on a fix and is further along than I was

@andygrove
Copy link
Contributor

I am working on fixes

@Salonijain27 Salonijain27 removed the ? - Needs Triage Need team to review and classify label Sep 14, 2021
@sameerz sameerz added this to the Sep 13 - Sep 24 milestone Sep 14, 2021
@andygrove
Copy link
Contributor

Fixed by #3496 and #3485

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P0 Must have for release
Projects
None yet
Development

No branches or pull requests

6 participants