Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Followup comments from PR3411 #3440

Closed
tgravescs opened this issue Sep 10, 2021 · 1 comment
Closed

[BUG] Followup comments from PR3411 #3440

tgravescs opened this issue Sep 10, 2021 · 1 comment
Assignees
@tgravescs
Labels
bug Something isn't working
Milestone
Sep 13 - Sep 24

Comments

@tgravescs
Copy link
Collaborator

Describe the bug
there were a few nits in #3411 that need to be followed up on.

  1. the shade plugin outputs dependency-reduced-pom.xml under the pom's basedir by default since we were not using dependencyReducedPomLocation config. As a consequence many developers who have used the old build in their local repo prior to this PR will have a stale file under dist that is not cleaned up by maven
    I suggest to add it to the exclude list in this PR to minimize reported build failures.
    In a follow up we can add dependencyReducedPomLocation to the shade plugin configs

  2. see other comments from Bobby.
@tgravescs tgravescs added bug Something isn't working ? - Needs Triage Need team to review and classify labels Sep 10, 2021
@tgravescs tgravescs self-assigned this Sep 10, 2021
@tgravescs tgravescs changed the title [BUG] Followup comment from PR3411 [BUG] Followup comments from PR3411 Sep 10, 2021
This was referenced Sep 10, 2021
Merged
Merged
Closed
@tgravescs tgravescs removed the ? - Needs Triage Need team to review and classify label Sep 10, 2021
@sameerz sameerz added this to the Sep 13 - Sep 24 milestone Sep 11, 2021
@tgravescs
Copy link
Collaborator Author

dependency-reduced-pom.xml was handled under 906af85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tgravescs tgravescs

Labels
bug Something isn't working
Projects
None yet
Milestone
Sep 13 - Sep 24
Development

Successfully merging a pull request may close this issue.

Update location of dependency reduced pom tgravescs/spark-rapids
2 participants
@tgravescs @sameerz