Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Support Sort on nested struct #2878

Closed
viadea opened this issue Jul 7, 2021 · 2 comments · Fixed by #3034
Closed

[FEA] Support Sort on nested struct #2878

viadea opened this issue Jul 7, 2021 · 2 comments · Fixed by #3034
Labels
feature request New feature or request

Comments

@viadea
Copy link
Collaborator

viadea commented Jul 7, 2021

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I wish the RAPIDS Accelerator for Apache Spark would [...]
Support Sort on nested struct.

Currently the Sort can only work on nested struct:

!Exec <SortExec> cannot run on GPU because not all expressions can be replaced
  !Expression <SortOrder> col#74 ASC NULLS FIRST cannot run on GPU because expression AttributeReference col#74 produces an unsupported type StructType(StructField(name,StructType(StructField(firstname,StringType,true)...

Describe the solution you'd like
A clear and concise description of what you want to happen.
GpuSort should work on nested struct.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context, code examples, or references to existing implementations about the feature request here.

@viadea viadea added feature request New feature or request ? - Needs Triage Need team to review and classify labels Jul 7, 2021
@viadea
Copy link
Collaborator Author

viadea commented Jul 7, 2021

This use case is to sort on a single-level struct or a two-level struct with primitive type.

@sameerz
Copy link
Collaborator

sameerz commented Jul 15, 2021

For this use case we will only support the default null ordering in Spark, and document that limitation.

@Salonijain27 Salonijain27 removed the ? - Needs Triage Need team to review and classify label Jul 27, 2021
@jlowe jlowe linked a pull request Jul 27, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
4 participants