Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow on issues for GpuSize #1974

Closed
revans2 opened this issue Mar 19, 2021 · 3 comments
Closed

Follow on issues for GpuSize #1974

revans2 opened this issue Mar 19, 2021 · 3 comments
Assignees
Labels
task Work required that improves the product but is not user facing

Comments

@revans2
Copy link
Collaborator

revans2 commented Mar 19, 2021

The GpuSize work #1972 will fix the failing nightly tests, so we are going to merge it in fast, but there are a few things that should be fixed in follow on work.

  1. cudf has an API to do exactly what we want. We should use that API instead of hacking together something ourselves.
  2. The signature for the input parameters are not strictly correct. They are not technically wrong either. The problem is that they say that we can support anything as the child of a map or array, but we have not plumbed through a lot of things calendar interval, or UDT. For the types that we support we should either extend the tests to cover some examples of these, or we should remove them from the list of supported types. Just so we are cautious and also so our documentation is as accurate as possible.

On a side note I should have a PR up shortly for countElements so we can get this done ASAP.

@revans2 revans2 added ? - Needs Triage Need team to review and classify task Work required that improves the product but is not user facing labels Mar 19, 2021
@revans2 revans2 added this to the Mar 15 - March 26 milestone Mar 19, 2021
@revans2
Copy link
Collaborator Author

revans2 commented Mar 19, 2021

I just put up the PR rapidsai/cudf#7651 in CUDF for the changes that are needed there to do this the right way.

@sperlingxx
Copy link
Collaborator

Thank you, @revans2. I've put up a PR to fix this.

@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Mar 29, 2021
@sameerz
Copy link
Collaborator

sameerz commented Mar 29, 2021

@sperlingxx is this resolved? If so can you mark the issue closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Work required that improves the product but is not user facing
Projects
None yet
Development

No branches or pull requests

3 participants