Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] support GpuLiteral of ArrayType #1902

Closed
sperlingxx opened this issue Mar 9, 2021 · 1 comment · Fixed by #2313
Closed

[FEA] support GpuLiteral of ArrayType #1902

sperlingxx opened this issue Mar 9, 2021 · 1 comment · Fixed by #2313
Assignees
Labels
feature request New feature or request

Comments

@sperlingxx
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently, GpuLiteral doesn't support nested types (Array, Struct, Map). Because underlying cuDF.Scalar doesn't support nested rapids types. Meanwhile, GpuLiteral of ArrayType is the essential feature for GpuExplode and other GpuExpressions. For now, we have a substituted implementation, which provide partial support of GpuLiteral on ArrayData. We should replace the temporary solution once cuDF support Scalar on ListType.

@sperlingxx sperlingxx added feature request New feature or request ? - Needs Triage Need team to review and classify labels Mar 9, 2021
@revans2
Copy link
Collaborator

revans2 commented Mar 16, 2021

rapidsai/cudf#7584 is adding in support for list scalars, and it looks like it will support full nesting of types because it takes a column_view as the data passed in. We will need to make java APIs for it and also verify that it will work to create a ColumnVector from a scalar value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants