Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [BUILD] CI passes without checking for operatorsScore.csv, supportedExprs.csv update #11896

Closed
mythrocks opened this issue Dec 19, 2024 · 1 comment · Fixed by #11910
Closed

[BUG] [BUILD] CI passes without checking for operatorsScore.csv, supportedExprs.csv update #11896

mythrocks opened this issue Dec 19, 2024 · 1 comment · Fixed by #11910
Assignees
@YanxuanLiu
Labels
? - Needs Triage Need team to review and classify bug Something isn't working build Related to CI / CD or cleanly building

Comments

@mythrocks
Copy link
Collaborator

mythrocks commented Dec 19, 2024 •
edited
Loading

Pre-merge CI seems to be passing without checking for checking for operatorsScore.csv and supportedExprs.csv being updated appropriately.

Case in point: #11833 introduced TruncDate and TruncTimestamp support. The PR updated operatorsScore.csv and supportedExprs.csv for most Spark versions, but not all. (For instance, 3**cdh, 35*, etc. were left out.)

It would be best if the pre-merge simply didn't pass for the cases where these files weren't updated for every supported version.

(#11890 will patch the symptoms for the moment.)
@mythrocks mythrocks added ? - Needs Triage Need team to review and classify bug Something isn't working build Related to CI / CD or cleanly building labels Dec 19, 2024
@mythrocks mythrocks mentioned this issue Dec 19, 2024
Merged
@pxLi
Copy link
Collaborator

pxLi commented Jan 3, 2025 •
edited
Loading

cc @YanxuanLiu to help to see why we did not catch the modified files in verify check thanks

@YanxuanLiu YanxuanLiu mentioned this issue Jan 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YanxuanLiu YanxuanLiu

Labels
? - Needs Triage Need team to review and classify bug Something isn't working build Related to CI / CD or cleanly building
Projects
None yet
Milestone
No milestone
3 participants
@mythrocks @pxLi @YanxuanLiu