Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Support escape characters in search list when rewrite regexp_replace to string replace #11812

Closed
thirtiseven opened this issue Dec 3, 2024 · 0 comments · Fixed by #11813
Assignees
Labels
performance A performance related task/issue

Comments

@thirtiseven
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
#7967 added a performance improvement of regexp_replace to transpile simple choice-type regular expressions into lists of choices to use with string replace multi. But when the search list contains some escape characters like \n, \r and \t, we won't go that path.

I hope we can support these cases so more patterns can be speed up.

Describe the solution you'd like

Filter those valid escape characters from regexList, in the isSupportedStringReplacePattern function. And add a test to verify that this behaviour happens.

@thirtiseven thirtiseven added ? - Needs Triage Need team to review and classify feature request New feature or request labels Dec 3, 2024
@thirtiseven thirtiseven self-assigned this Dec 3, 2024
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Dec 3, 2024
@sameerz sameerz added performance A performance related task/issue and removed feature request New feature or request labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance A performance related task/issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants