You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Not all APIs from the libraries we use are best-suited to our use case. Some are designed rather for other use cases. Some are simply designed badly. These APIs are considered as "unsafe" as they require us to pay more attention when using them. Wrong use of those APIs would introduce nasty bugs, which would not be caught during the build or the test but only after thorough debugging. An example of such bugs can be found in #11364. I was only able to locate the bug after executing the code line by line during the whole query processing. We should be able to avoid such issues in the first place, so that we could spend our time on more interesting problems.
Describe the solution you'd like
We could forbid use of such APIs if they are considered unsafe for our use case. With the forbidden API checker, we could register unsafe APIs, so that use of them would be caught during the build. In case we have to use unsafe APIs, we would have to explicitly skip the checker at certain lines. A downside is that the build time may increase.
Describe alternatives you've considered
I am not sure if there are alternatives besides just being careful when using them, which is what we do today.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
Not all APIs from the libraries we use are best-suited to our use case. Some are designed rather for other use cases. Some are simply designed badly. These APIs are considered as "unsafe" as they require us to pay more attention when using them. Wrong use of those APIs would introduce nasty bugs, which would not be caught during the build or the test but only after thorough debugging. An example of such bugs can be found in #11364. I was only able to locate the bug after executing the code line by line during the whole query processing. We should be able to avoid such issues in the first place, so that we could spend our time on more interesting problems.
Describe the solution you'd like
We could forbid use of such APIs if they are considered unsafe for our use case. With the forbidden API checker, we could register unsafe APIs, so that use of them would be caught during the build. In case we have to use unsafe APIs, we would have to explicitly skip the checker at certain lines. A downside is that the build time may increase.
Describe alternatives you've considered
I am not sure if there are alternatives besides just being careful when using them, which is what we do today.
The text was updated successfully, but these errors were encountered: