Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback TimeZoneAwareExpression that only support UTC with zoneId instead of timeZone config #10995

Closed
thirtiseven opened this issue Jun 7, 2024 · 0 comments · Fixed by #10996
Assignees
Labels
bug Something isn't working

Comments

@thirtiseven
Copy link
Collaborator

In some TimeZoneAwareExpression that plugin supports only UTC, the expression will fallback according to GpuOverrides.isUTCTimezone. In some case like when we call an expression directly by passing a timezone as it's parameter, like in Spark UT:

checkEvaluation(
      StructsToJson(Map.empty, struct, Option(PST.getId)),
      """{"t":"2015-12-31T16:00:00.000-08:00"}"""
    )

The fallback doesn't work because it didn't change any configuration.

For expressions that support timezone, we will check the expr.zoneId in BaseExprMeta.getZoneId(), I hope we can use it instead of reading config when checking UTC timezone too.

@thirtiseven thirtiseven added bug Something isn't working ? - Needs Triage Need team to review and classify labels Jun 7, 2024
@thirtiseven thirtiseven self-assigned this Jun 7, 2024
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants