Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] failed to build JNI with latest kvikIO compat mode change #2609

Closed
pxLi opened this issue Nov 20, 2024 · 2 comments
Closed

[BUG] failed to build JNI with latest kvikIO compat mode change #2609

pxLi opened this issue Nov 20, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@pxLi
Copy link
Collaborator

pxLi commented Nov 20, 2024

Describe the bug
submodule sync and cudf JNI build failed after rapidsai/kvikio#547

[2024-11-20T03:15:49.612Z] [INFO]      [exec] /home/jenkins/agent/workspace/jenkins-spark-rapids-jni_submodule-sync-dev-3978/thirdparty/cudf/cpp/src/io/utilities/config_utils.cpp: In lambda function:

[2024-11-20T03:15:49.613Z] [INFO]      [exec] /home/jenkins/agent/workspace/jenkins-spark-rapids-jni_submodule-sync-dev-3978/thirdparty/cudf/cpp/src/io/utilities/config_utils.cpp:60:41: error: cannot convert 'const bool' to 'kvikio::CompatMode'

[2024-11-20T03:15:49.613Z] [INFO]      [exec]    60 |     kvikio::defaults::compat_mode_reset(compat_mode);

[2024-11-20T03:15:49.613Z] [INFO]      [exec]       |                                         ^~~~~~~~~~~

[2024-11-20T03:15:49.613Z] [INFO]      [exec]       |                                         |

[2024-11-20T03:15:49.613Z] [INFO]      [exec]       |                                         const bool

[2024-11-20T03:15:49.613Z] [INFO]      [exec] In file included from /home/jenkins/agent/workspace/jenkins-spark-rapids-jni_submodule-sync-dev-3978/thirdparty/cudf/cpp/src/io/utilities/config_utils.cpp:21:

[2024-11-20T03:15:49.613Z] [INFO]      [exec] /home/jenkins/agent/workspace/jenkins-spark-rapids-jni_submodule-sync-dev-3978/target/libcudf/cmake-build/_deps/kvikio-src/cpp/include/kvikio/defaults.hpp:226:44: note:   initializing argument 1 of 'static void kvikio::defaults::compat_mode_reset(kvikio::CompatMode)'

[2024-11-20T03:15:49.613Z] [INFO]      [exec]   226 |   static void compat_mode_reset(CompatMode compat_mode) { instance()->_compat_mode = compat_mode; }

[2024-11-20T03:15:49.613Z] [INFO]      [exec]       |                                 ~~~~~~~~~~~^~~~~~~~~~~

[2024-11-20T03:15:49.868Z] [INFO]      [exec] [ 58%] Building CXX object CMakeFiles/cudf.dir/src/io/utilities/data_sink.cpp.o

Steps/Code to reproduce bug
Please provide a list of steps or a code sample to reproduce the issue.
Avoid posting private or sensitive data.

Expected behavior
A clear and concise description of what you expected to happen.

Environment details (please complete the following information)

  • Environment location: [Standalone, YARN, Kubernetes, Cloud(specify cloud provider)]
  • Spark configuration settings related to the issue

Additional context
Add any other context about the problem here.

@pxLi pxLi added ? - Needs Triage bug Something isn't working labels Nov 20, 2024
@gerashegalov
Copy link
Collaborator

Now there is a PR in libcudf to fix it rapidsai/cudf#17377

@jlowe
Copy link
Member

jlowe commented Nov 20, 2024

submodule sync is working again after the libcudf fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants