Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup get_json_object #2232

Merged
merged 13 commits into from
Jul 17, 2024
Merged

Conversation

ttnghia
Copy link
Collaborator

@ttnghia ttnghia commented Jul 16, 2024

This does some cleaning up work, including:

  • Change enum type to inherit from int8_t and reorganize class member variables to reduce padding. As such, class instances occupy less memory.
  • Add const and static qualifier to member functions.
  • Remove redundant code.
  • Construct path commands without stream sync, etc.

No new functionality is added in this PR.

@ttnghia ttnghia added the enhancement New feature or request label Jul 16, 2024
@ttnghia ttnghia requested review from thirtiseven and res-life July 16, 2024 22:19
@ttnghia ttnghia self-assigned this Jul 16, 2024
Signed-off-by: Nghia Truong <[email protected]>
@ttnghia
Copy link
Collaborator Author

ttnghia commented Jul 16, 2024

build

@ttnghia ttnghia merged commit aff3696 into NVIDIA:branch-24.08 Jul 17, 2024
3 checks passed
@ttnghia ttnghia deleted the cleanup_get_json_object branch July 17, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants