Fix completion condition for get_json_object with wildcard paths but empty input array
#2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nghia Truong <[email protected]>
ttnghia
force-pushed
the
fix_get_json_object_not_return
branch
from
9a2bc94 to
f9b08dc
Compare
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases when we have wildcard paths (
[*]) but the input array corresponding to it is an empty array, the current code does not report as complete after parsing past the end of the array. Instead, it continues parsing the input string indefinitely until the end of the string. Although that does not produce an incorrect output, it is a wrong behavior.This fixes such behavior, allowing the code to terminate correctly.