Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Mark all kernels with hidden visibility #1734

Closed
ttnghia opened this issue Jan 25, 2024 · 3 comments · Fixed by #2168
Closed

[FEA] Mark all kernels with hidden visibility #1734

ttnghia opened this issue Jan 25, 2024 · 3 comments · Fixed by #2168
Assignees

Comments

@ttnghia
Copy link
Collaborator

ttnghia commented Jan 25, 2024

To avoid potential issues when using a static cuda runtime in the library, we need to hide all kernels from the external world. This can be done by using the static keyword or hidden visibility adding to the kernel declaration, similar to what has been done in cudf: rapidsai/cudf#14726.

For example, we can use this macro instead of __global__:

#ifndef JNI_KERNEL
# define JNI_KERNEL __attribute__ ((visibility ("hidden"))) __global__
#endif
@mattahrens
Copy link
Collaborator

Additional documentation needed to show how to do this properly with UDFs.

@jlowe
Copy link
Member

jlowe commented Jan 30, 2024

Additional documentation needed to show how to do this properly with UDFs.

Filed NVIDIA/spark-rapids-examples#356 to track updating the native UDF examples in the spark-rapids-examples repository.

@jihoonson
Copy link
Collaborator

I'm working on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants