Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Support templated fixture tests #24

Closed
PointKernel opened this issue Jul 13, 2021 · 2 comments
Closed

[FEA] Support templated fixture tests #24

PointKernel opened this issue Jul 13, 2021 · 2 comments

Comments

@PointKernel
Copy link
Member

All cudf benchmarks use templated fixture tests to handle rmm memory pool allocation/deallocation. It will be great if this functionality can be supported by nvbench.
@karthikeyann
Copy link

We can relax the constraint about templates. The fixture does not need to be templated for cudf.
Most benchmarks are templated benchmark functions with non-templated fixture.
AFAIK, templated-fixture is written for some benchmarks because google benchmark does not support templated benchmarks with non-templated fixture yet.

@karthikeyann karthikeyann mentioned this issue Dec 7, 2021
Merged
2 tasks
@jrhemstad
Copy link
Collaborator

Superseded by #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@karthikeyann @PointKernel @jrhemstad