This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Block local memory tests on pascal #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmaxey
added
the
testing: internal ci in progress
griwes
approved these changes
Nov 4, 2022
.upstream-tests/test/std/atomics/atomics.types.generic/atomic_copyable.pass.cpp
Outdated
Show resolved
Hide resolved
wmaxey
commented
Nov 4, 2022
| @@ -18,9 +18,13 @@ | |||
|
|
|||
| #include "test_macros.h" | |||
|
|
|||
| // NVRTC doesn't include host atomic making this feature test invalid | |||
| // TODO: Should we define __cpp_lib_atomic_is_always_lock_free for NVRTC? | |||
There was a problem hiding this comment.
@griwes Food for thought regarding macro. We don't do this now for anything so it's going to have to be another PR.
wmaxey
added
testing: internal ci passed
miscco
approved these changes
Nov 4, 2022
|
@wmaxey can you update the PR description with what this change is for? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pascal cannot use the general scoped atomics for
.localmemory, I don't know if it can use the.localscoped atomics to avoid this issue which is our next planned refactor. This is not the case for SM_70 and doesn't appear to be documented anywhere. This PR then changes all the tests to instead exclusively test shared/global memory on Pascal.PR makes Pascal tests happy which in turn makes CI happy.
https://blossom.nvidia.com/sw-cuda-cccl-instance/blue/organizations/jenkins/cluster_launch_test/detail/cluster_launch_test/311/pipeline/1062