Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I also noticed that the option of FP8 operand and FP16 accumulator is excluded in ss_op_selector and rs_op_selector, even though this is accommodated by the PTX ISA and otherwise has MMA_Traits structs defined for it (F16E4M3E4M3 etc.). This is done by the following code: #1646

Closed
ylz1104 opened this issue Jul 22, 2024 · 1 comment

Comments

@ylz1104
Copy link

ylz1104 commented Jul 22, 2024

          I also noticed that the option of FP8 operand and FP16 accumulator is excluded in `ss_op_selector` and `rs_op_selector`, even though this is accommodated by the PTX ISA and otherwise has `MMA_Traits` structs defined for it (F16E4M3E4M3 etc.). This is done by the following code:
// FP16 accumulator
  if constexpr (is_same_v<ElementC, half_t>) {
    static_assert(is_same_v<ElementA, half_t>, "Element types for AB must be half if ElementC is half.");
    static_assert(is_same_v<ElementB, half_t>, "Element types for AB must be half if ElementC is half.");

Was this intentional or is this an oversight?

Originally posted by @jayhshah in #1268 (comment)

@thakkarV
Copy link
Collaborator

just an oversight. we do not really have a use for them today, but if you do you are welcome to add them or ask us to add them.

@mnicely mnicely closed this as completed Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants