Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] About the rounding mode of TF32 #1289

Closed
beginlner opened this issue Jan 3, 2024 · 3 comments
Closed

[BUG] About the rounding mode of TF32 #1289

beginlner opened this issue Jan 3, 2024 · 3 comments

Comments

@beginlner
Copy link

beginlner commented Jan 3, 2024

https://github.com/NVIDIA/cutlass/blob/main/include/cutlass/tfloat32.h#L80
Why does the code represent "round toward nearest even", but not "round to nearest, ties away from zero"?

@beginlner beginlner changed the title About the rounding mode of TF32 [Bug] About the rounding mode of TF32 Jan 3, 2024
@beginlner beginlner changed the title [Bug] About the rounding mode of TF32 [BUG] About the rounding mode of TF32 Jan 3, 2024
@hwu36
Copy link
Collaborator

hwu36 commented Jan 5, 2024

I don't fully understand your questions. Exactly as this rounding method says, it "round_half_ulp_truncate", so it is not "to the nearest even"

we do this because it only takes two instructions to do the conversion.

Copy link

github-actions bot commented Feb 4, 2024

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@mnicely
Copy link
Collaborator

mnicely commented Feb 22, 2024

Closing due to inactivity

@mnicely mnicely closed this as completed Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants